[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 12:39:13 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, Marcin Szycik
<marcin.szycik@...ux.intel.com>, Wojciech Drewek <wojciech.drewek@...el.com>,
Yury Norov <yury.norov@...il.com>, Andy Shevchenko <andy@...nel.org>, "Rasmus
Villemoes" <linux@...musvillemoes.dk>, Alexander Potapenko
<glider@...gle.com>, Jiri Pirko <jiri@...nulli.us>, Ido Schimmel
<idosch@...dia.com>, Simon Horman <horms@...nel.org>,
<linux-btrfs@...r.kernel.org>, <dm-devel@...hat.com>,
<ntfs3@...ts.linux.dev>, <linux-s390@...r.kernel.org>,
<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8()
use bitmap_{read,write}()
On 2/1/24 13:22, Alexander Lobakin wrote:
> Now that we have generic bitmap_read() and bitmap_write(), which are
> inline and try to take care of non-bound-crossing and aligned cases
> to keep them optimized, collapse bitmap_{get,set}_value8() into
> simple wrappers around the former ones.
> bloat-o-meter shows no difference in vmlinux and -2 bytes for
> gpio-pca953x.ko, which says the optimization didn't suffer due to
> that change. The converted helpers have the value width embedded
> and always compile-time constant and that helps a lot.
>
> Suggested-by: Yury Norov <yury.norov@...il.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> ---
> include/linux/bitmap.h | 38 +++++---------------------------------
> 1 file changed, 5 insertions(+), 33 deletions(-)
>
Hah, nice!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Powered by blists - more mailing lists