linux-kernel - Re: [PATCH 1/1] PCI: Cleanup link activation wait logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 14:22:10 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
    linux-kernel@...r.kernel.org, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH 1/1] PCI: Cleanup link activation wait logic

On Fri, 2 Feb 2024, Ilpo Järvinen wrote:

> 1. Change pcie_failed_link_retrain() to return true only if link was
>    retrained successfully due to the Target Speed quirk. If there is no
>    LBMS set, return false instead of true because no retraining was
>    even attempted. This seems correct considering expectations of both
>    callers of pcie_failed_link_retrain().

 You change the logic here in that the second conditional isn't run if the 
first has not.  This is wrong, unclamping is not supposed to rely on LBMS. 
It is supposed to be always run and any failure has to be reported too, as 
a retraining error.  I'll send an update according to what I have outlined 
before then, with some testing done first.

> 2. Handle link-was-not-retrained-successfully return (false) from
>    pcie_failed_link_retrain() properly in pcie_wait_for_link_delay() by
>    directly returning false.

 I think it has to be a separate change, as a fix to what I can see is an 
issue with a three-way-merge done with commit 1abb47390350 ("Merge branch 
'pci/enumeration'"); surely a bool result wasn't supposed to be assigned 
to an int variable carrying an error code.

 Either or both changes may have to be backported independently.

  Maciej