linux-kernel - Re: [PATCH v3 2/4] sched/fair: remove unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 02 Feb 2024 15:27:24 +0100
From: Valentin Schneider <vschneid@...hat.com>
To: alexs@...nel.org, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra
 <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, Vincent
 Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann
 <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben
 Segall <bsegall@...gle.com>, Daniel Bristot de Oliveira
 <bristot@...hat.com>, linux-kernel@...r.kernel.org,
 ricardo.neri-calderon@...ux.intel.com, sshegde@...ux.ibm.com
Cc: Alex Shi <alexs@...nel.org>
Subject: Re: [PATCH v3 2/4] sched/fair: remove unused parameters

On 01/02/24 19:54, alexs@...nel.org wrote:
> From: Alex Shi <alexs@...nel.org>
>
> sds isn't used in function sched_asym(), so remove it to cleanup code.
>
> Signed-off-by: Alex Shi <alexs@...nel.org>
> Reviewed-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>

AFAICT this is unsused as of:
  c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing")

Reviewed-by: Valentin Schneider <vschneid@...hat.com>

> To: Valentin Schneider <vschneid@...hat.com>
> To: Vincent Guittot <vincent.guittot@...aro.org>
> To: Juri Lelli <juri.lelli@...hat.com>
> To: Peter Zijlstra <peterz@...radead.org>
> To: Ingo Molnar <mingo@...hat.com>
> ---
>  kernel/sched/fair.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 46ba8329b10a..8d70417f5125 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9750,7 +9750,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu)
>  /**
>   * sched_asym - Check if the destination CPU can do asym_packing load balance
>   * @env:	The load balancing environment
> - * @sds:	Load-balancing data with statistics of the local group
>   * @sgs:	Load-balancing statistics of the candidate busiest group
>   * @group:	The candidate busiest group
>   *
> @@ -9769,8 +9768,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu)
>   * otherwise.
>   */
>  static inline bool
> -sched_asym(struct lb_env *env, struct sd_lb_stats *sds,  struct sg_lb_stats *sgs,
> -	   struct sched_group *group)
> +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group)
>  {
>       /* Ensure that the whole local core is idle, if applicable. */
>       if (!sched_use_asym_prio(env->sd, env->dst_cpu))
> @@ -9941,7 +9939,7 @@ static inline void update_sg_lb_stats(struct lb_env *env,
>       /* Check if dst CPU is idle and preferred to this group */
>       if (!local_group && env->sd->flags & SD_ASYM_PACKING &&
>           env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running &&
> -	    sched_asym(env, sds, sgs, group)) {
> +	    sched_asym(env, sgs, group)) {
>               sgs->group_asym_packing = 1;
>       }
>
> --
> 2.43.0