| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Feb 2024 17:12:01 +0800
From: Zhao Liu <zhao1.liu@...ux.intel.com>
To: Paolo Bonzini <pbonzini@...hat.com>,
Sean Christopherson <seanjc@...gle.com>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>,
"H . Peter Anvin" <hpa@...or.com>,
kvm@...r.kernel.org,
linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org,
x86@...nel.org
Cc: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
Len Brown <len.brown@...el.com>,
Zhang Rui <rui.zhang@...el.com>,
Zhenyu Wang <zhenyu.z.wang@...el.com>,
Zhuocheng Ding <zhuocheng.ding@...el.com>,
Dapeng Mi <dapeng1.mi@...el.com>,
Yanting Jiang <yanting.jiang@...el.com>,
Yongwei Ma <yongwei.ma@...el.com>,
Vineeth Pillai <vineeth@...byteword.org>,
Suleiman Souhlal <suleiman@...gle.com>,
Masami Hiramatsu <mhiramat@...gle.com>,
David Dai <davidai@...gle.com>,
Saravana Kannan <saravanak@...gle.com>,
Zhao Liu <zhao1.liu@...el.com>
Subject: [RFC 13/26] KVM: VMX: Support virtual HFI table for VM
From: Zhuocheng Ding <zhuocheng.ding@...el.com>
The Hardware Feedback Interface (HFI) is a feature that allows hardware
to provide guidance to the operating system scheduler through a hardware
feedback interface structure (HFI table) in memory [1], so that the
scheduler can perform optimal workload scheduling.
ITD (Intel Thread Director) and HFI features both depend on the HFI
table, but their HFI tables are slightly different. The HFI table
provided by the ITD feature has 4 classes (in terms of more columns
in the table) and the native HFI feature supports 1 class [2].
In fact, the size of the HFI table is determined by the feature bit that
the processor supports, but the range of data updates in the table
is determined by the feature actually enabled (HFI or ITD) [3], which is
controlled by MSR_IA32_HW_FEEDBACK_CONFIG.
To benefit the scheduling in VM with HFI/ITD, we need to maintain
virtual HFI tables in KVM. The virtual HFI table is based on the real
HFI table. We extract the HFI entries corresponding to the pCPU that the
vCPU is running on, and reorganize these actual entries into a new
virtual HFI table with the vCPU's HFI index.
Also, to simplify the logic, before the emulation of ITD is supported,
we build virtual HFI table based on HFI feature by default (i.e. only 1
class is supported, based on class 0 of real hardware).
Add the interfaces to initialize and build the virtual HFI table, and to
inject the thermal interrupt into the VM to notify about HFI updates.
[1]: SDM, vol. 3B, section 15.6 HARDWARE FEEDBACK INTERFACE AND INTEL
THREAD DIRECTOR
[2]: SDM, vol. 3B, section 15.6.2 Intel Thread Director Table Structure
[3]: SDM, vol. 3B, section 15.6.5 Hardware Feedback Interface
Configuration, Table 15-10. IA32_HW_FEEDBACK_CONFIG Control Option
Tested-by: Yanting Jiang <yanting.jiang@...el.com>
Signed-off-by: Zhuocheng Ding <zhuocheng.ding@...el.com>
Co-developed-by: Zhao Liu <zhao1.liu@...el.com>
Signed-off-by: Zhao Liu <zhao1.liu@...el.com>
---
arch/x86/kvm/vmx/vmx.c | 119 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 119 insertions(+)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 96f0f768939d..7881f6b51daa 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -1532,6 +1532,125 @@ static void vmx_inject_therm_interrupt(struct kvm_vcpu *vcpu)
kvm_apic_therm_deliver(vcpu);
}
+static inline bool vmx_hfi_initialized(struct kvm_vmx *kvm_vmx)
+{
+ return kvm_vmx->pkg_therm.hfi_desc.hfi_enabled &&
+ kvm_vmx->pkg_therm.hfi_desc.table_ptr_valid;
+}
+
+static inline bool vmx_hfi_int_enabled(struct kvm_vmx *kvm_vmx)
+{
+ return kvm_vmx->pkg_therm.hfi_desc.hfi_int_enabled;
+}
+
+static int vmx_init_hfi_table(struct kvm *kvm)
+{
+ struct kvm_vmx *kvm_vmx = to_kvm_vmx(kvm);
+ struct hfi_desc *kvm_vmx_hfi = &kvm_vmx->pkg_therm.hfi_desc;
+ struct hfi_features *hfi_features = &kvm_vmx_hfi->hfi_features;
+ struct hfi_table *hfi_table = &kvm_vmx_hfi->hfi_table;
+ int nr_classes, ret = 0;
+
+ /*
+ * Currently we haven't supported ITD. HFI is the default feature
+ * with 1 class.
+ */
+ nr_classes = 1;
+ ret = intel_hfi_build_virt_features(hfi_features,
+ nr_classes,
+ kvm->created_vcpus);
+ if (unlikely(ret))
+ return ret;
+
+ hfi_table->base_addr = kzalloc(hfi_features->nr_table_pages <<
+ PAGE_SHIFT, GFP_KERNEL);
+ if (!hfi_table->base_addr)
+ return -ENOMEM;
+
+ hfi_table->hdr = hfi_table->base_addr + sizeof(*hfi_table->timestamp);
+ hfi_table->data = hfi_table->hdr + hfi_features->hdr_size;
+ return 0;
+}
+
+static int vmx_build_hfi_table(struct kvm *kvm)
+{
+ struct kvm_vmx *kvm_vmx = to_kvm_vmx(kvm);
+ struct hfi_desc *kvm_vmx_hfi = &kvm_vmx->pkg_therm.hfi_desc;
+ struct hfi_features *hfi_features = &kvm_vmx_hfi->hfi_features;
+ struct hfi_table *hfi_table = &kvm_vmx_hfi->hfi_table;
+ struct hfi_hdr *hfi_hdr = hfi_table->hdr;
+ int nr_classes, ret = 0, updated = 0;
+ struct kvm_vcpu *v;
+ unsigned long i;
+
+ /*
+ * Currently we haven't supported ITD. HFI is the default feature
+ * with 1 class.
+ */
+ nr_classes = 1;
+ for (int j = 0; j < nr_classes; j++) {
+ hfi_hdr->perf_updated = 0;
+ hfi_hdr->ee_updated = 0;
+ hfi_hdr++;
+ }
+
+ kvm_for_each_vcpu(i, v, kvm) {
+ ret = intel_hfi_build_virt_table(hfi_table, hfi_features,
+ nr_classes,
+ to_vmx(v)->hfi_table_idx,
+ v->cpu);
+ if (unlikely(ret < 0))
+ return ret;
+ updated |= ret;
+ }
+
+ if (!updated)
+ return updated;
+
+ /* Timestamp must be monotonic. */
+ (*kvm_vmx_hfi->hfi_table.timestamp)++;
+
+ /* Update the HFI table, whether the HFI interrupt is enabled or not. */
+ kvm_write_guest(kvm, kvm_vmx_hfi->table_base, hfi_table->base_addr,
+ hfi_features->nr_table_pages << PAGE_SHIFT);
+ return 1;
+}
+
+static void vmx_update_hfi_table(struct kvm *kvm)
+{
+ struct kvm_vmx *kvm_vmx = to_kvm_vmx(kvm);
+ struct hfi_desc *kvm_vmx_hfi = &kvm_vmx->pkg_therm.hfi_desc;
+ int ret = 0;
+
+ if (!intel_hfi_enabled())
+ return;
+
+ if (!vmx_hfi_initialized(kvm_vmx))
+ return;
+
+ if (!kvm_vmx_hfi->hfi_table.base_addr) {
+ ret = vmx_init_hfi_table(kvm);
+ if (unlikely(ret))
+ return;
+ }
+
+ ret = vmx_build_hfi_table(kvm);
+ if (ret <= 0)
+ return;
+
+ kvm_vmx_hfi->hfi_update_status = true;
+ kvm_vmx_hfi->hfi_update_pending = false;
+
+ /*
+ * Since HFI is shared for all vCPUs of the same VM, we
+ * actually support only 1 package topology VMs, so when
+ * emulating package level interrupt, we only inject an
+ * interrupt into one vCPU to reduce the overhead.
+ */
+ if (vmx_hfi_int_enabled(kvm_vmx))
+ vmx_inject_therm_interrupt(kvm_get_vcpu(kvm, 0));
+}
+
/*
* Switches to specified vcpu, until a matching vcpu_put(), but assumes
* vcpu mutex is already taken.
--
2.34.1
Powered by blists - more mailing lists