linux-kernel - Re: [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e9030cc-3431-45c5-a7a8-0da02bafab09@linaro.org>
Date: Sat, 3 Feb 2024 15:49:21 +0100
From: neil.armstrong@...aro.org
To: Mike Tipton <quic_mdtipton@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, djakov@...nel.org
Cc: quic_rjendra@...cinc.com, quic_sibis@...cinc.com, abel.vesa@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV
 enable_mask

On 02/02/2024 02:48, Mike Tipton wrote:
> The ACV enable_mask is historically BIT(3), but it's BIT(0) on this
> target. Fix it.
> 
> Fixes: c062bcab5924 ("interconnect: qcom: introduce RPMh Network-On-Chip Interconnect on SM8650 SoC")
> Signed-off-by: Mike Tipton <quic_mdtipton@...cinc.com>
> ---
>   drivers/interconnect/qcom/sm8650.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/qcom/sm8650.c b/drivers/interconnect/qcom/sm8650.c
> index b83de54577b6..b962e6c233ef 100644
> --- a/drivers/interconnect/qcom/sm8650.c
> +++ b/drivers/interconnect/qcom/sm8650.c
> @@ -1160,7 +1160,7 @@ static struct qcom_icc_node qns_gemnoc_sf = {
>   
>   static struct qcom_icc_bcm bcm_acv = {
>   	.name = "ACV",
> -	.enable_mask = BIT(3),
> +	.enable_mask = BIT(0),
>   	.num_nodes = 1,
>   	.nodes = { &ebi },
>   };

Indeed it changed in the meantime


Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>