linux-kernel - Re: [PATCH] iio: humidity: hdc3020: add threshold events support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871e7e7a-c987-4926-957e-5dfdb46d0740@gmail.com>
Date: Sat, 3 Feb 2024 16:53:33 +0100
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Li peiyu <579lpy@...il.com>, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: add threshold events support

On 03.02.24 15:42, Dimitri Fedrau wrote:
> Am Sat, Feb 03, 2024 at 10:30:09AM +0100 schrieb Javier Carrasco:
>> Hi Dimitri,
>>
> Hi Javier,
> 
>>> +	/* Supported temperature range is from –40 to 125 degree celsius */
>> Should that not be val < -40?
> yes, you are right. Will fix it.
>>> +	if (val < -45 || val > 125)
>>> +		return -EINVAL;
>>> +
> 
> Best regards,
> Dimitri

When at it, could you please rename the hdc3020_id variable you added to
the probe function? It shadows the i2c_device_id global variable (it is
not used in the probe function, but there is no need to use the exact
same name), and given that it is in the hdc3020_probe function,
mentioning the device name again is kind of redundant. Something like
just "id" or "dev_id" would suffice.

Best regards,
Javier Carrasco