linux-kernel - [PATCH 0/2] checkpatch: relax >75 warning, adjust report format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240203195527.212505-1-jim.cromie@gmail.com>
Date: Sat,  3 Feb 2024 12:55:25 -0700
From: Jim Cromie <jim.cromie@...il.com>
To: linux-kernel@...r.kernel.org,
	akpm@...uxfoundation.org
Cc: joe@...ches.com,
	Jim Cromie <jim.cromie@...il.com>
Subject: [PATCH 0/2] checkpatch: relax >75 warning, adjust report format

1. current checkpatch warns: "Prefer a maximum 75 chars per line"
on [1]:

[1] https://lore.kernel.org/lkml/20200825153338.17061-1-vincent.whitchurch@axis.com

That is overly strict.  Instead allow long non-whitespace strings
(\S+) to exceed 75 chars, after tolerating \s in 1st 10 chars.

This is more permissive than the current Fixes/link detector (which I
preserved), IMHO checkpatch shouldn't be that fussy; it doesn't verify
URLs either.

2. adjust report format for nicer pararaphs.

Current checkpatch format uses -------------- lines to segment the
many per-patch reports, but then inserts a blank line just above the
last per-patch report line, breaking the paragraph nature of that
report.

Move the blank line down, which places it just above the -------- line
starting the next per-patch report.  Also wrap the per-patch summary
line, so its columnar position is independent of the patch-name (and
its length), and so your terminal window doesn't have to wrap the
line.  This makes the report easier to visually scroll/scan, since the
status is always in the same column.

IOW, from this:

0001-checkpatch-report last line, looks part of 0002
--------------------------------------------------------------
0002-checkpatch-minor-whitespace-changes-for-readability.patch
--------------------------------------------------------------
total: 0 errors, 0 warnings, 15 lines checked

0002-checkpatch-minor-whitespace-changes-for-readability.patch has ....
-------------------------------------------------
next-patch ...

To this:

--------------------------------------------------------------
0002-checkpatch-minor-whitespace-changes-for-readability.patch
--------------------------------------------------------------
total: 0 errors, 0 warnings, 15 lines checked
0002-checkpatch-minor-whitespace-changes-for-readability.patch 
 has no obvious style problems and is ready for submission.

-------------------------------------------------
next-patch ...

Jim Cromie (2):
  checkpatch: tolerate long lines w/o spaces
  checkpatch: minor whitespace changes for readability

 scripts/checkpatch.pl | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.43.0