linux-kernel - Re: Re: [lvc-project] [PATCH] i2c: Fix NULL pointer dereference in npcm_i2c_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zb6luAVHcnX2fXz3@shikoro>
Date: Sat, 3 Feb 2024 21:44:40 +0100
From: Wolfram Sang <wsa@...nel.org>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Tali Perry <tali.perry1@...il.com>, Rand Deeb <rand.sec96@...il.com>,
	lvc-project@...uxtesting.org, voskresenski.stanislav@...fident.ru,
	Benjamin Fair <benjaminfair@...gle.com>,
	Avi Fishman <avifishman70@...il.com>,
	Patrick Venture <venture@...gle.com>, openbmc@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, Nancy Yuen <yuenn@...gle.com>,
	linux-i2c@...r.kernel.org, deeb.rand@...fident.ru,
	Tomer Maimon <tmaimon77@...il.com>
Subject: Re: Re: [lvc-project] [PATCH] i2c: Fix NULL pointer dereference in
 npcm_i2c_reg_slave


> If I'm not missing something, npcm_i2c_reg_slave() is called via a
> function pointer ->reg_slave here [1]. And seems `client` can't be NULL
> there. Other drivers implementing ->reg_slave function don't check its
> argument.

Correct, we trust ourselves here.

> Maybe we should just drop `if (!bus->slave)` check?

Yes.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)