linux-kernel - Re: [PATCH 2/2] iio: adc: ti-ads1298: Add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 13:06:00 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mike Looijmans <mike.looijmans@...ic.nl>, devicetree@...r.kernel.org,
 linux-iio@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, Haibo Chen
 <haibo.chen@....com>, Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Lars-Peter Clausen <lars@...afoo.de>, Lee Jones <lee@...nel.org>, Leonard
 Göhrs <l.goehrs@...gutronix.de>, Liam Beguin
 <liambeguin@...il.com>, Liam Girdwood <lgirdwood@...il.com>, Maksim Kiselev
 <bigunclemax@...il.com>, Marcus Folkesson <marcus.folkesson@...il.com>,
 Marius Cristea <marius.cristea@...rochip.com>, Mark Brown
 <broonie@...nel.org>, Niklas Schnelle <schnelle@...ux.ibm.com>, Okan Sahin
 <okan.sahin@...log.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti-ads1298: Add driver

On Thu, 1 Feb 2024 13:38:16 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Wed, Jan 31, 2024 at 05:10:08PM +0100, Mike Looijmans wrote:
> > On 13-12-2023 15:55, Andy Shevchenko wrote:  
> > > On Wed, Dec 13, 2023 at 10:47:22AM +0100, Mike Looijmans wrote:  
> 
> First of all, please remove unneeded context, don't make me waste time on doing
> that for you!
> 
> ...
> 
> > > 		*val = sign_extend32(get_unaligned_be24(priv->rx_buffer + chan->address),
> > > 				     23);  
> > 
> > Doesn't fit, first line is 83 characters by my count...  
> 
> Is it a problem?

To add a bit more info here. For IIO at least (and most of the rest of the kernel)
it's fine to go over 80 chars if there is a significant cost in readability to break
the line.  Here that is the case + you are only going 3 chars over so it's fine
to do so.

Jonathan

> 
>