linux-kernel - Re: [PATCH] arm: omap1: remove duplicated 'select ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASC4xh5WrEaHkqFg49xzJsQMQnjLV8sCea8uceNp5EUdQ@mail.gmail.com>
Date: Sun, 4 Feb 2024 22:18:53 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Aaro Koskinen <aaro.koskinen@....fi>, Janusz Krzysztofik <jmkrzyszt@...il.com>, 
	Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Russell King <linux@...linux.org.uk>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'

Just a nit.

The commit subject "arm:" should be capitalized to "ARM:"
because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?


On Sun, Feb 4, 2024 at 9:57 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
> added one more 'select ARCH_OMAP'.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  arch/arm/mach-omap1/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
> index cbf703f0d850..a643b71e30a3 100644
> --- a/arch/arm/mach-omap1/Kconfig
> +++ b/arch/arm/mach-omap1/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
>         depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
>         depends on CPU_LITTLE_ENDIAN
>         depends on ATAGS
> -       select ARCH_OMAP
>         select ARCH_HAS_HOLES_MEMORYMODEL
>         select ARCH_OMAP
>         select CLKSRC_MMIO
> --
> 2.40.1
>


-- 
Best Regards
Masahiro Yamada