linux-kernel - Re: [PATCH v2 2/2] iio: adc: ad7380: don't use bool in FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 14:46:07 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 2/2] iio: adc: ad7380: don't use bool in FIELD_PREP

On Mon, 29 Jan 2024 13:56:08 -0600
David Lechner <dlechner@...libre.com> wrote:

> Although this technically works, it is better to avoid using bool as
> a bit value.
> 
> Fixes sparse warning:
> 
>      drivers/iio/adc/ad7380.c:353:34: sparse: sparse: dubious: x & !y
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401280629.5kknB57C-lkp@intel.com/
> Signed-off-by: David Lechner <dlechner@...libre.com>
Applied.
> ---
> 
> v2 changes:
> * use correct terinary operator syntax (had typo of : instead of ?)
> 
>  drivers/iio/adc/ad7380.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index 44b8b18ab213..abd746aef868 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -350,7 +350,8 @@ static int ad7380_init(struct ad7380_state *st)
>  	/* select internal or external reference voltage */
>  	ret = regmap_update_bits(st->regmap, AD7380_REG_ADDR_CONFIG1,
>  				 AD7380_CONFIG1_REFSEL,
> -				 FIELD_PREP(AD7380_CONFIG1_REFSEL, !!st->vref));
> +				 FIELD_PREP(AD7380_CONFIG1_REFSEL,
> +					    st->vref ? 1 : 0));
>  	if (ret < 0)
>  		return ret;
>