linux-kernel - Re: [PATCH] iio: accel: Fix a compilation problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 15:16:05 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, "open list:IIO SUBSYSTEM AND
 DRIVERS" <linux-iio@...r.kernel.org>, open list
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: accel: Fix a compilation problem

On Wed, 31 Jan 2024 16:52:46 -0600
Mario Limonciello <mario.limonciello@....com> wrote:

> The kernel fails when compiling without `CONFIG_REGMAP_I2C` but with
> `CONFIG_BMA400`.
> ```
> ld: drivers/iio/accel/bma400_i2c.o: in function `bma400_i2c_probe':
> bma400_i2c.c:(.text+0x23): undefined reference to `__devm_regmap_init_i2c'
> ```
> 
> This was caught with one of the kconfigs used by the LKP robot for a
> separate issue.
> 
> Link: https://download.01.org/0day-ci/archive/20240131/202401311634.FE5CBVwe-lkp@intel.com/config
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Good catch.  Ideally would have a fixes tag but it's a bit complex in this
case as they two parts landed in different series.
I've added both tags and marked it for stable.

Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400")
Fixes: 9bea10642396 ("iio: accel: bma400: add support for bma400 spi")

> ---
>  drivers/iio/accel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 91adcac875a4..c9d7afe489e8 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -219,10 +219,12 @@ config BMA400
>  
>  config BMA400_I2C
>  	tristate
> +	select REGMAP_I2C
>  	depends on BMA400
>  
>  config BMA400_SPI
>  	tristate
> +	select REGMAP_SPI
>  	depends on BMA400
>  
>  config BMC150_ACCEL