linux-kernel - Re: [PATCH v7 20/39] mtd: rawnand: add support for ts72xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 4 Feb 2024 18:49:45 +0200
From: andy.shevchenko@...il.com
To: Nikita Shubin <nikita.shubin@...uefel.me>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	Christophe Kerello <christophe.kerello@...s.st.com>,
	Chris Packham <chris.packham@...iedtelesis.co.nz>,
	Daniel Golle <daniel@...rotopia.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Johan Jonker <jbx6244@...il.com>, Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v7 20/39] mtd: rawnand: add support for ts72xx

Thu, Jan 18, 2024 at 11:21:03AM +0300, Nikita Shubin kirjoitti:
> Technologic Systems has it's own nand controller implementation in CPLD.

..

> +err_clean_nand:
> +	nand_cleanup(&data->chip);
> +err_handle_put:
> +	fwnode_handle_put(child);
> +	return err;
> +}
> +
> +static void ts72xx_nand_remove(struct platform_device *pdev)
> +{
> +	struct ts72xx_nand_data *data = platform_get_drvdata(pdev);
> +	struct nand_chip *chip = &data->chip;
> +	int ret;
> +
> +	ret = mtd_device_unregister(nand_to_mtd(chip));
> +	WARN_ON(ret);
> +	nand_cleanup(chip);

Missing fwnode_handle_put()?

> +}


-- 
With Best Regards,
Andy Shevchenko