linux-kernel - Re: [PATCH] mm/z3fold: remove unneeded spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zb_bhO8Z_d7VUCdJ@casper.infradead.org>
Date: Sun, 4 Feb 2024 18:46:28 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Zhongkun He <hezhongkun.hzk@...edance.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/z3fold: remove unneeded spinlock

On Sun, Feb 04, 2024 at 08:54:04PM +0800, Zhongkun He wrote:
> There is no need to use spinlock in this section, so
> remove it.

I don't know this code at all, but the idiom is (relatively) common.
It waits until anybody _currently_ holding the lock has released it.

That would, eg, make it safe to free the 'pool' memory.

> -	spin_lock(&pool->lock);
> -	spin_unlock(&pool->lock);