linux-kernel - Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeKyvec=xpfmyNrpqg5szFjD6FfbQNUFXN2Y4__j1B_UQ@mail.gmail.com>
Date: Sun, 4 Feb 2024 21:55:43 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()

On Sun, Feb 4, 2024 at 8:24 PM Vladimir Oltean <olteanv@...il.com> wrote:
> On Sun, Feb 04, 2024 at 06:21:06PM +0200, andy.shevchenko@...il.com wrote:
> > Use `ret = dev_err_probe(...);` pattern for all messages in dspi_request_dma()
> > for the sake of uniforming them. While at it, fix indentation issue reported
> > by Vladimir Oltean.
>
> When did I do that? This is v1.

In the original submission (v2 of it to be precise) by Minjie.

..

> >       ret = dmaengine_slave_config(dma->chan_rx, &cfg);
> >       if (ret) {
> > -             dev_err(dev, "can't configure rx dma channel\n");
> > -             ret = -EINVAL;
> > +             ret = dev_err_probe(dev, -EINVAL, "can't configure rx dma channel\n");
>
> Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the "ret"
> from dmaengine_slave_config().

True, but this patch doesn't change the behaviour.

..

> >       if (ret) {
> > -             dev_err(dev, "can't configure tx dma channel\n");
> > -             ret = -EINVAL;
> > +             ret = dev_err_probe(dev, -EINVAL, "can't configure tx dma channel\n");
>
> Same here.

Same answer here.

> >               goto err_slave_config;
> >       }

-- 
With Best Regards,
Andy Shevchenko