linux-kernel - Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcLtzJ7heNxfEGxNJbkjbnHSLJTSHCcMnEQfLUTnbwkRw@mail.gmail.com>
Date: Sun, 4 Feb 2024 21:56:34 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()

On Sun, Feb 4, 2024 at 8:31 PM Vladimir Oltean <olteanv@...il.com> wrote:
> On Sun, Feb 04, 2024 at 08:24:17PM +0200, Vladimir Oltean wrote:

..

> > Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the "ret"
> > from dmaengine_slave_config().

> Ah, the original code also ignores the dmaengine_slave_config() return
> code and replaces it with -EINVAL? I wonder why that is... It doesn't
> appear to be a widespread pattern. Pretty arbitrary. Could you please
> make 2 patches, one which preserves the original return code and another
> which uses dev_err_probe()?

Sure.

-- 
With Best Regards,
Andy Shevchenko