[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fccd3a15-b3a1-4ea2-ad0f-a6c0d3a8e134@ieee.org>
Date: Sun, 4 Feb 2024 15:06:25 -0600
From: Alex Elder <elder@...e.org>
To: "Ricardo B. Marliere" <ricardo@...liere.net>,
Ilya Dryomov <idryomov@...il.com>,
Dongsheng Yang <dongsheng.yang@...ystack.cn>, Jens Axboe <axboe@...nel.dk>
Cc: ceph-devel@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] block: rbd: make rbd_bus_type const
On 2/4/24 9:31 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
Great!
Reviewed-by: Alex Elder <elder@...aro.org>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 0202a4e5d6cf..21f2b9e9b9ff 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -575,7 +575,7 @@ static const struct attribute_group rbd_bus_group = {
> };
> __ATTRIBUTE_GROUPS(rbd_bus);
>
> -static struct bus_type rbd_bus_type = {
> +static const struct bus_type rbd_bus_type = {
> .name = "rbd",
> .bus_groups = rbd_bus_groups,
> };
>
> ---
> base-commit: aa826a9b19b93bf8aabc462381ae436a60b2a320
> change-id: 20240204-bus_cleanup-block-9986bfea7975
>
> Best regards,
Powered by blists - more mailing lists