[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <oixce2fflwe6rodxsv625ogbymqlblw7qvvbxmtp7tpgarqpju@ufnqi7j364md>
Date: Sun, 4 Feb 2024 22:29:51 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: "Ricardo B. Marliere" <ricardo@...liere.net>
Cc: Thorsten Scherer <t.scherer@...elmann.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] siox: make siox_bus_type const
Hello Ricardo,
On Sun, Feb 04, 2024 at 05:36:03PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the siox_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> ---
> drivers/siox/siox-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
> sdriver->shutdown(sdevice);
> }
>
> -static struct bus_type siox_bus_type = {
> +static const struct bus_type siox_bus_type = {
> .name = "siox",
> .match = siox_match,
> .probe = siox_probe,
while I like this change, I wonder about the "Now" in the commit log.
Doing the homework, this is about commit d492cc2573a0 ("driver core:
device.h: make struct bus_type a const *") which is in 6.4-rc1. Would
you please care to mention that commit as the one that makes this siox
change possible?
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists