linux-kernel - Re: [RFC PATCH] kprobes: Use synchronize_rcu_tasks_rude in kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbeebd04-f8c2-866b-0016-79778c64cab8@huawei.com>
Date: Sun, 4 Feb 2024 09:16:36 +0800
From: Yang Jihong <yangjihong1@...wei.com>
To: <paulmck@...nel.org>
CC: Chen Zhongjin <chenzhongjin@...wei.com>, <linux-kernel@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>, <naveen.n.rao@...ux.ibm.com>,
	<anil.s.keshavamurthy@...el.com>, <davem@...emloft.net>,
	<mhiramat@...nel.org>, <akpm@...ux-foundation.org>, <tglx@...utronix.de>,
	<peterz@...radead.org>, <pmladek@...e.com>, <dianders@...omium.org>,
	<npiggin@...il.com>, <mpe@...erman.id.au>, <jkl820.git@...il.com>,
	<juerg.haefliger@...onical.com>, <rick.p.edgecombe@...el.com>,
	<eric.devolder@...cle.com>, <mic@...ikod.net>
Subject: Re: [RFC PATCH] kprobes: Use synchronize_rcu_tasks_rude in
 kprobe_optimizer

Hello,

On 2024/2/4 6:00, Paul E. McKenney wrote:
> On Mon, Jan 29, 2024 at 08:58:10AM +0800, Yang Jihong wrote:
>> Hello,
>>
>> On 2024/1/28 3:22, Paul E. McKenney wrote:
>>> On Tue, Jan 09, 2024 at 07:28:29PM +0800, Yang Jihong wrote:
>>>> Hello,
>>>>
>>>> PING.
>>>>
>>>> I had a similar problem. Is this solution feasible?
>>>
>>> Sadly, no.
>>>
>>> It fails on CONFIG_PREEMPT=y kernels because synchronize_rcu_tasks_rude()
>>> will not wait on tasks that have been preempted while executing in
>>> a trampoline.
>>>
>>> But could you please try out the patch shown at the end of this email?
>>
>> Thanks for the patch, yes, I've tested and it solves the problem.
> 
> Very good, and thank you for testing it!
> 
> May I apply your Tested-by to the commit to record your efforts for
> posterity?
> 
Sure absolutely.

Tested-by: Yang Jihong <yangjihong1@...wei.com>

Thanks,
Yang