linux-kernel - Re: [PATCH v2 4/4] iio: pressure: hsc030pa add triggered buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcEPJh1i7cc0xyBW@sunspire>
Date: Mon, 5 Feb 2024 18:39:02 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: andy.shevchenko@...il.com
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 4/4] iio: pressure: hsc030pa add triggered buffer


hello Andy,

On Sun, Feb 04, 2024 at 06:03:28PM +0200, andy.shevchenko@...il.com wrote:
[..]
> > +	memcpy(&data->scan.chan[1], &data->buffer[2], 2);
> 
> Hmm... We don't have fixed-size memcpy() :-(

	__be16 *ptr;

	ptr = (__be16 *) data->buffer;
	data->scan.chan[0] = *ptr;
	data->scan.chan[1] = *++ptr;

is this an acceptable replacement? I do not understand that your concern was, my
intent was to copy exactly 2 bytes over.

> > +	iio_push_to_buffers_with_timestamp(indio_dev, &data->scan,
> > +					   iio_get_time_ns(indio_dev));

thanks,
peter

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)