lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <93e93056-d75c-4b12-a161-1e410f3ac354@gmx.de>
Date: Mon, 5 Feb 2024 18:02:29 +0100
From: Armin Wolf <W_Armin@....de>
To: "Ricardo B. Marliere" <ricardo@...liere.net>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2] platform: x86: wmi: make wmi_bus_type const

Am 04.02.24 um 15:40 schrieb Ricardo B. Marliere:

> Now that the driver core can properly handle constant struct bus_type,
> move the wmi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> ---
>   drivers/platform/x86/wmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 7ef1e82dc61c..859dfff515d0 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -219,7 +219,7 @@ static int wmidev_match_guid(struct device *dev, const void *data)
>   	return 0;
>   }
>
> -static struct bus_type wmi_bus_type;
> +static const struct bus_type wmi_bus_type;
>
>   static struct wmi_device *wmi_find_device_by_guid(const char *guid_string)
>   {
> @@ -899,7 +899,7 @@ static struct class wmi_bus_class = {
>   	.name = "wmi_bus",
>   };
>
> -static struct bus_type wmi_bus_type = {
> +static const struct bus_type wmi_bus_type = {
>   	.name = "wmi",
>   	.dev_groups = wmi_groups,
>   	.match = wmi_dev_match,
>
Reviewed-by: Armin Wolf <W_Armin@....de>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ