linux-kernel - Re: [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55fa1c14-87ef-46ef-8871-f7139f86e8b7@acm.org>
Date: Mon, 5 Feb 2024 09:08:08 -0800
From: Bart Van Assche <bvanassche@....org>
To: alice.chao@...iatek.com, Alim Akhtar <alim.akhtar@...sung.com>,
 Avri Altman <avri.altman@....com>, "James E.J. Bottomley"
 <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: wsd_upstream@...iatek.com, stanley.chu@...iatek.com,
 peter.wang@...iatek.com, powen.kao@...iatek.com, naomi.chu@...iatek.com,
 cc.chou@...iatek.com, tun-yu.yu@...iatek.com, chun-hung.wu@...iatek.com,
 casper.li@...iatek.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear_cmd

On 2/5/24 02:49, alice.chao@...iatek.com wrote:
> When task_tag > 32 (in mcq mode), 1U << task_tag will out of bound
        ^^^^^^^^^^^^^
        task_tag >= 32 and sizeof(unsigned int) == 4

> for u32 mask. Fix this bug to prevent SHIFT_ISSUE (Bitwise shifts
> that are out of bounds for their data type).

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>