[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62e2f525-4178-432e-9732-b886e0fcf65c@intel.com>
Date: Mon, 5 Feb 2024 10:24:02 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: "Ricardo B. Marliere" <ricardo@...liere.net>, Jon Mason
<jdmason@...zu.us>, Allen Hubbe <allenbh@...il.com>
Cc: ntb@...ts.linux.dev, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/2] ntb: core: make ntb_bus const
On 2/4/24 9:22 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the ntb_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
> drivers/ntb/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ntb/core.c b/drivers/ntb/core.c
> index 27dd93deff6e..f32b77c7e00d 100644
> --- a/drivers/ntb/core.c
> +++ b/drivers/ntb/core.c
> @@ -72,7 +72,7 @@ MODULE_VERSION(DRIVER_VERSION);
> MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESCRIPTION);
>
> -static struct bus_type ntb_bus;
> +static const struct bus_type ntb_bus;
> static void ntb_dev_release(struct device *dev);
>
> int __ntb_register_client(struct ntb_client *client, struct module *mod,
> @@ -292,7 +292,7 @@ static void ntb_dev_release(struct device *dev)
> complete(&ntb->released);
> }
>
> -static struct bus_type ntb_bus = {
> +static const struct bus_type ntb_bus = {
> .name = "ntb",
> .probe = ntb_probe,
> .remove = ntb_remove,
>
Powered by blists - more mailing lists