[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cea9bc906796cdbfdd85a8c36ea5eb11a25979a7.camel@perches.com>
Date: Mon, 05 Feb 2024 09:38:25 -0800
From: Joe Perches <joe@...ches.com>
To: Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org,
akpm@...uxfoundation.org
Subject: Re: [PATCH 2/2] checkpatch: minor whitespace changes for readability
On Sat, 2024-02-03 at 12:55 -0700, Jim Cromie wrote:
> Change the per-patch report format slightly, so its more paragraphic,
> and easier to peruse/scan.
>
> OLD FORM:
>
> 0001-checkpatch-report last line, looks part of 0002 has no ...
> --------------------------------------------------------------
> 0002-checkpatch-minor-whitespace-changes-for-readability.patch
> --------------------------------------------------------------
> total: 0 errors, 0 warnings, 15 lines checked
>
> 0002-checkpatch-minor-whitespace-changes-for-readability.patch has no ...
> --------------------------------------------------------------
>
> NEW FORM:
>
> --------------------------------------------------------------
> 0002-checkpatch-minor-whitespace-changes-for-readability.patch
> --------------------------------------------------------------
> total: 0 errors, 0 warnings, 15 lines checked
> 0002-checkpatch-minor-whitespace-changes-for-readability.patch
> has no obvious style problems and is ready for submission.
>
> --------------------------------------------------------------
>
> For the optimum (warning free) patchset, the new report format is a
> series of single paragraphs (with the --- banners), one for each patch
> in the series. This is trivial to scan/peruse, and is also more
> visually distinct from warning/error reports.
>
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
> scripts/checkpatch.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dc17c6da3af2..cd249ae9abdd 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -7796,12 +7796,12 @@ EOM
> }
>
> if ($quiet == 0) {
> - print "\n";
> if ($clean == 1) {
> - print "$vname has no obvious style problems and is ready for submission.\n";
> + print "$vname \n has no obvious style problems and is ready for submission.\n";
Space after filename / $vname isn't necessary.
> } else {
> - print "$vname has style problems, please review.\n";
> + print "$vname \n has style problems, please review.\n";
here too.
> }
> + print "\n";
> }
> return $clean;
> }
Powered by blists - more mailing lists