[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <z47adbiweldcumlq4uejggkfcvfaw5nrd7v3tbh2e3pcvzjot2@gourfue5ytbl>
Date: Mon, 5 Feb 2024 23:39:12 +0530
From: Amit Machhiwal <amachhiw@...ux.ibm.com>
To: Vaibhav Jain <vaibhav@...ux.ibm.com>
Cc: linuxppc-dev@...ts.ozlabs.org, kvm@...r.kernel.org,
kvm-ppc@...r.kernel.org, linux-kernel@...r.kernel.org,
Nicholas Piggin <npiggin@...il.com>,
Vaidyanathan Srinivasan <svaidy@...ux.ibm.com>,
"Aneesh Kumar K . V" <aneesh.kumar@...nel.org>,
Jordan Niethe <jniethe5@...il.com>,
"Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>
Subject: Re: Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure
due to empty 'arch_compat'
Hi Vaibhav,
Thanks for looking into the patch.
On 2024/02/05 11:05 PM, Vaibhav Jain wrote:
> Hi Amit,
>
> Thanks for the patch. Minor comment on the patch below:
>
> Amit Machhiwal <amachhiw@...ux.ibm.com> writes:
>
> <snip>
>
> >
> > +static inline unsigned long map_pcr_to_cap(unsigned long pcr)
> > +{
> > + unsigned long cap = 0;
> > +
> > + switch (pcr) {
> > + case PCR_ARCH_300:
> > + cap = H_GUEST_CAP_POWER9;
> > + break;
> > + case PCR_ARCH_31:
> > + cap = H_GUEST_CAP_POWER10;
> Though CONFIG_CC_IMPLICIT_FALLTHROUGH and '-Wimplicit-fallthrough'
> doesnt explicitly flag this usage, please consider using the
> 'fallthrough;' keyword here.
>
> However you probably dont want this switch-case to fallthrough so please
> use a 'break' instead.
Sure, v3 on the way.
>
> > + default:
> > + break;
> > + }
> > +
> > + return cap;
> > +}
> > +
> >
> <snip>
>
> With the suggested change above
>
> Reviewed-by: Vaibhav Jain <vaibhav@...ux.ibm.com>
Thanks!
>
> --
> Cheers
> ~ Vaibhav
~Amit
Powered by blists - more mailing lists