[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53e6862c-89dd-40ec-94ba-04a2e1a995b7@web.de>
Date: Mon, 5 Feb 2024 19:29:13 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
kernel-janitors@...r.kernel.org, Jörg Rödel
<joro@...tes.org>, Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in
ipmmu_probe()
>> Thus reuse existing functionality instead of keeping duplicate source code.
>
> Much as I detest the get_and_ioremap_resource obfuscator, it's not even appropriate here since nothing else is using "res".
Another adjustment might follow for the application of the function “devm_platform_ioremap_resource”.
https://elixir.bootlin.com/linux/v6.8-rc3/source/drivers/base/platform.c#L112
Regards,
Markus
Powered by blists - more mailing lists