linux-kernel - Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bBW08=reuD7UfkJfzumVx3ZFYJuD4ptriW4paBiNKV8Hw@mail.gmail.com>
Date: Mon, 5 Feb 2024 13:51:19 -0500
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Robin Murphy <robin.murphy@....com>
Cc: joro@...tes.org, will@...nel.org, iommu@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, rientjes@...gle.com, 
	yosryahmed@...gle.com, john.g.garry@...cle.com
Subject: Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure

On Mon, Feb 5, 2024 at 10:32 AM Robin Murphy <robin.murphy@....com> wrote:
>
> Failure handling in iova_cache_get() is a little messy, and we'd like
> to add some more to it, so let's tidy up a bit first. By leaving the
> hotplug handler until last we can take advantage of kmem_cache_destroy()
> being NULL-safe to have a single cleanup label. We can also improve the
> error reporting, noting that kmem_cache_create() already screams if it
> fails, so that one is redundant.
>
> Signed-off-by: Robin Murphy <robin.murphy@....com>

Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

Thank you,
Pasha