linux-kernel - Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240205201920.GA2220@sol.localdomain>
Date: Mon, 5 Feb 2024 12:19:20 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Kshitiz Varshney <kshitiz.varshney@....com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	dl-linux-imx <linux-imx@....com>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Varun Sethi <V.Sethi@....com>, Gaurav Jain <gaurav.jain@....com>,
	Pankaj Gupta <pankaj.gupta@....com>,
	Sahil Malhotra <sahil.malhotra@....com>,
	Vabhav Sharma <vabhav.sharma@....com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@....com>,
	Rahul Kumar Yadav <rahulkumar.yadav@....com>,
	Nikhil Singla <nikhil.singla@....com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test
 as built in module.

On Mon, Feb 05, 2024 at 12:29:33PM +0100, Kshitiz Varshney wrote:
> Issue:-
> Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
> skcipher: failed to allocate transform for xctr(aes): -2
> alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> alg: self-tests for sm3 using sm3 failed (rc=-2)
> tcrypt: failed to load transform for sm3: -2
> alg: hash: failed to allocate transform for polyval: -2
> alg: self-tests for polyval using polyval failed (rc=-2)
> 
> Resolution:-
> Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
> CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
> sm3, sm4, aria, polyval & xctr.
> 
> Signed-off-by: Kshitiz Varshney <kshitiz.varshney@....com>

This looks like an issue in tcrypt.  When algorithms are unavailable it should
consider the corresponding test cases to be skipped, not failed.

>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++

There should be no need to enable every crypto algorithm in every defconfig
file.  Can you consider fixing the underlying issue instead of doing that?

- Eric