linux-kernel - Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and convert several tasklet users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMdWSLNMqsZNJ-oCLN2RjckZmJSvdU_Yq0F0frmqMqa67Oy1g@mail.gmail.com>
Date: Mon, 5 Feb 2024 12:50:28 -0800
From: Allen <allen.lkml@...il.com>
To: Tejun Heo <tj@...nel.org>
Cc: torvalds@...ux-foundation.org, mpatocka@...hat.com, 
	linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev, msnitzer@...hat.com, 
	ignat@...udflare.com, damien.lemoal@....com, bob.liu@...cle.com, 
	houtao1@...wei.com, peterz@...radead.org, mingo@...nel.org, 
	netdev@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and
 convert several tasklet users

> On Mon, Jan 29, 2024 at 11:11:47PM -1000, Tejun Heo wrote:
> >  0001-workqueue-Update-lock-debugging-code.patch
> >  0002-workqueue-Factor-out-init_cpu_worker_pool.patch
> >  0003-workqueue-Implement-BH-workqueues-to-eventually-repl.patch
> >  0004-backtracetest-Convert-from-tasklet-to-BH-workqueue.patch
> >  0005-usb-core-hcd-Convert-from-tasklet-to-BH-workqueue.patch
> >  0006-net-tcp-tsq-Convert-from-tasklet-to-BH-workqueue.patch
> >  0007-dm-crypt-Convert-from-tasklet-to-BH-workqueue.patch
> >  0008-dm-verity-Convert-from-tasklet-to-BH-workqueue.patch
>
> Applied 0001-0003 to wq/for-6.9. Applied 0004-0005 to
> wq/for-6.9-bh-conversions. Will proceed on 0006 and other conversions after
> more perf testing.
>
> Thanks.
>

Thank you. I am basing my work on the branch you have
pushed.(or-6.9-bh-conversions)
https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/log/?h=for-6.9-bh-conversions

In the order of priority, I have started converting drivers/media/*,
drivers/dma/* followed by drivers/net/*
which constitutes the majority. Putting my plan out here so that the
work is not duplicated.
I will write back in a day and share the branch for review.

W.r.t the conversion, there are drivers which call
tasklet_[disable/enable](), which I suppose
can be ignored in the case of workqueues, I am not entirely sure if
this is the right approach.
Please correct me if I am wrong.

Thanks,

  - Allen