linux-kernel - Re: [PATCH v3 2/2] dt-bindings: power: supply: st,stc3117

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 08:48:31 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Bhavin Sharma <bhavin.sharma@...iconsignals.io>, sre@...nel.org,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: power: supply: st,stc3117

On 05/02/2024 06:13, Bhavin Sharma wrote:
> Signed-off-by: Bhavin Sharma <bhavin.sharma@...iconsignals.io>

You cannot have empty commits.

Subject: It's empty? What happened there?

> ---
> Changelogs :
> 
> v2 -> v3
> - Resolved DTC warnings and errors
> - Formatted the changelogs
> - Added monitored battery properties
> - Replaced 'additionalProperties' with 'unevaluatedProperties'
> - Replaced '&i2c6' with 'i2c'
> 
> v1 -> v2
> - String value is redundantly quoted with any quotes (quoted-strings)
> - Found character '\t' that cannot start any token
> ---

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

>  .../bindings/power/supply/st,stc3117.yaml     | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
> new file mode 100644
> index 000000000000..9ab0b0d6b30e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Dual license, just like checkpatch asks.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/st,stc3117.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STC3117 Fuel Gauge Unit Power Supply
> +
> +maintainers:
> +  - Bhavin Sharma <bhavin.sharma@...iconsignals.io>
> +  - Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
> +
> +allOf:
> +  - $ref: power-supply.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stc3117
> +
> +  reg:
> +    maxItems: 1

Are you going to answer my questions or just ignore them?

> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    bat: battery {

Drop node


> +       compatible = "simple-battery";
> +       device-chemistry = "lithium-ion-polymer";
> +       energy-full-design-microwatt-hours = <16800000>;
> +       charge-full-design-microamp-hours = <4000000>;
> +       voltage-min-design-microvolt = <3000000>;
> +    };
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      stc3117@70 {

Still wrong name.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof