[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <abe2930b-8fd0-4fa7-8abe-a036525a21ce@linaro.org>
Date: Mon, 5 Feb 2024 09:39:59 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Abdel Alkuor <alkuor@...il.com>, Pavel Machek <pavel@....cz>,
Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
Alice Chen <alice_chen@...htek.com>, ChiaEn Wu <chiaen_wu@...htek.com>,
ChiYuan Huang <cy_huang@...htek.com>, André Apitzsch
<git@...tzsch.eu>, Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller
On 03/02/2024 18:58, Abdel Alkuor wrote:
> NCP5623 is DC-DC multi-LED controller which can be used for
> RGB illumination or backlight LCD display. NCP5623
> provides 94% peak efficiency.
Drop marketing.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
It's dt-bindings.
>
> Signed-off-by: Abdel Alkuor <alkuor@...il.com>
> ---
> .../bindings/leds/onnn,ncp5623.yaml | 98 +++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml b/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
> new file mode 100644
> index 000000000000..696bc7d8c8f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/onnn,ncp5623.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor NCP5623 multi-LED Driver
> +
> +maintainers:
> + - Abdel Alkuor <alkuor@...il.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + NCP5623 Triple Output I2C Controlled LED Driver.
> + https://www.onsemi.com/pdf/datasheet/ncp5623-d.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - onnn,ncp5623
> +
> + reg:
> + enum:
Instead "const", or just maxItems: 1
> + - 0x38
> +
> + multi-led:
> + type: object
> + $ref: leds-class-multicolor.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^led@[0-2]$":
> + type: object
> + $ref: common.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + description: Index of the LED.
Drop description, it is obvious.
> + minimum: 0
> + maximum: 2
> +
> + required:
> + - reg
> + - color
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
Best regards,
Krzysztof
Powered by blists - more mailing lists