linux-kernel - Re: [PATCH v2] siox: make siox_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5zjixnsaylidn7t65thchwg5aa2igpwr34bmlfdtevvn4bgx2e@txzz36fi7rqz>
Date: Mon, 5 Feb 2024 10:03:30 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: "Ricardo B. Marliere" <ricardo@...liere.net>
Cc: Thorsten Scherer <t.scherer@...elmann.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] siox: make siox_bus_type const

Hello Ricardo,

On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>

I currently have no setup to test this, but compilation is fine, and I
don't expect any surprises.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for your patch,
Uwe

PS: b4 gave me:

  ✗ [PATCH v2] siox: make siox_bus_type const
  ✗ No key: openpgp/ricardo@...liere.net
  ✗ BADSIG: DKIM/marliere.net

when applying your patch. I didn't check the details of the DKIM issue. I
quickly tried to find your pgp key, but failed (wks, kernel-pgpkeys
repo, keyserver).

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)