linux-kernel - Re: [PATCH v7 01/39] ARM: ep93xx: Add terminator to gpiod_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <86ae775b-b3ab-45db-9541-95fcc0e17b5e@app.fastmail.com>
Date: Mon, 05 Feb 2024 10:02:06 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Nikita Shubin" <nikita.shubin@...uefel.me>
Cc: "Hartley Sweeten" <hsweeten@...ionengravers.com>,
 "Russell King" <linux@...linux.org.uk>, "Wu, Aaron" <Aaron.Wu@...log.com>,
 "Olof Johansson" <olof@...om.net>, "Lee Jones" <lee@...nel.org>,
 "Ralf Baechle" <ralf@...ux-mips.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, "Andy Shevchenko" <andriy.shevchenko@...el.com>
Subject: Re: [PATCH v7 01/39] ARM: ep93xx: Add terminator to gpiod_lookup_table

On Mon, Feb 5, 2024, at 09:42, Alexander Sverdlin wrote:
> Hi Arnd and all,
>
> On Fri, 2024-01-19 at 00:52 +0100, Linus Walleij wrote:
>> On Thu, Jan 18, 2024 at 9:22 AM Nikita Shubin via B4 Relay
>> <devnull+nikita.shubin.maquefel.me@...nel.org> wrote:
>> 
>> > From: Nikita Shubin <nikita.shubin@...uefel.me>
>> > 
>> > Without the terminator, if a con_id is passed to gpio_find() that
>> > does not exist in the lookup table the function will not stop looping
>> > correctly, and eventually cause an oops.
>> > 
>> > Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
>> > Reported-by: Andy Shevchenko <andriy.shevchenko@...el.com>
>> > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
>> 
>> Sorry, my bug...
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Cc: stable@...r.kernel.org
> Acked-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
>
> Arnd, could you please take this into arm-soc?
> I can send a PR, but this probably makes little sense for one patch?

I'm travelling at the moment, but can take it when I get back.

If you want to be sure it doesn't get lost, please send the
patch (with the Acks) to soc@...nel.org and it will end up
in patchwork.

   Arnd