[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <696c7ded128d46addc16ecafa6128822@linux.ibm.com>
Date: Mon, 05 Feb 2024 11:36:32 +0100
From: Harald Freudenberger <freude@...ux.ibm.com>
To: "Ricardo B. Marliere" <ricardo@...liere.net>
Cc: Vineeth Vijayan <vneethv@...ux.ibm.com>,
Peter Oberparleiter
<oberpar@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
<gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian
Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle
<svens@...ux.ibm.com>,
Tony Krowiak <akrowiak@...ux.ibm.com>,
Halil Pasic
<pasic@...ux.ibm.com>,
Jason Herne <jjherne@...ux.ibm.com>,
Greg
Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] s390: AP: make ap_bus_type const
On 2024-02-03 15:58, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the ap_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> ---
> drivers/s390/crypto/ap_bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/ap_bus.c
> b/drivers/s390/crypto/ap_bus.c
> index f46dd6abacd7..2ecf4d36e78b 100644
> --- a/drivers/s390/crypto/ap_bus.c
> +++ b/drivers/s390/crypto/ap_bus.c
> @@ -135,7 +135,7 @@ static int ap_max_domain_id = 15;
> /* Maximum adapter id, if not given via qci */
> static int ap_max_adapter_id = 63;
>
> -static struct bus_type ap_bus_type;
> +static const struct bus_type ap_bus_type;
>
> /* Adapter interrupt definitions */
> static void ap_interrupt_handler(struct airq_struct *airq,
> @@ -1603,7 +1603,7 @@ static struct attribute *ap_bus_attrs[] = {
> };
> ATTRIBUTE_GROUPS(ap_bus);
>
> -static struct bus_type ap_bus_type = {
> +static const struct bus_type ap_bus_type = {
> .name = "ap",
> .bus_groups = ap_bus_groups,
> .match = &ap_bus_match,
Reviewed-by: Harald Freudenberger <freude@...ux.ibm.com>
Powered by blists - more mailing lists