linux-kernel - Re: [PATCH] iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in ipmmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <324d4e02-6a5a-4112-a3a7-d7aeb5876acc@arm.com>
Date: Mon, 5 Feb 2024 11:11:03 +0000
From: Robin Murphy <robin.murphy@....com>
To: Markus Elfring <Markus.Elfring@....de>, iommu@...ts.linux.dev,
 kernel-janitors@...r.kernel.org, Jörg Rödel
 <joro@...tes.org>, Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Use
 devm_platform_get_and_ioremap_resource() in ipmmu_probe()

On 2024-02-05 10:42 am, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 5 Feb 2024 11:36:51 +0100
> 
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.

Much as I detest the get_and_ioremap_resource obfuscator, it's not even 
appropriate here since nothing else is using "res".

> This issue was detected by using the Coccinelle software.

Please improve your script, or at least manually review your patches to 
ensure they actually make sense in context. If you want to do cleanup, 
do thorough, meaningful cleanup - leaving weird dangling local variables 
does not make the code clearer, if anything it makes it subtly worse 
since now the reader's wondering why we've gone out of our way to make 
this unused assignment, so maybe something's missing and there's a bug?

Thanks,
Robin.

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>   drivers/iommu/ipmmu-vmsa.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index ace1fc4bd34b..12685dd2dd31 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -1025,8 +1025,7 @@ static int ipmmu_probe(struct platform_device *pdev)
>   		return ret;
> 
>   	/* Map I/O memory and request IRQ. */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	mmu->base = devm_ioremap_resource(&pdev->dev, res);
> +	mmu->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(mmu->base))
>   		return PTR_ERR(mmu->base);
> 
> --
> 2.43.0
>