linux-kernel - RE: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB6PR04MB3190048410A18A231D5B7FC08F472@DB6PR04MB3190.eurprd04.prod.outlook.com>
Date: Mon, 5 Feb 2024 11:42:19 +0000
From: Kshitiz Varshney <kshitiz.varshney@....com>
To: Shawn Guo <shawn.gsc@...il.com>
CC: Herbert Xu <herbert@...dor.apana.org.au>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	dl-linux-imx <linux-imx@....com>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Varun Sethi <V.Sethi@....com>, Gaurav Jain
	<gaurav.jain@....com>, Pankaj Gupta <pankaj.gupta@....com>, Sahil Malhotra
	<sahil.malhotra@....com>, Vabhav Sharma <vabhav.sharma@....com>, Meenakshi
 Aggarwal <meenakshi.aggarwal@....com>, Rahul Kumar Yadav
	<rahulkumar.yadav@....com>, Nikhil Singla <nikhil.singla@....com>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
 polyval, xctr cipher test support



> -----Original Message-----
> From: Shawn Guo <shawn.gsc@...il.com>
> Sent: Saturday, February 3, 2024 7:52 PM
> To: Kshitiz Varshney <kshitiz.varshney@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>; Shawn Guo
> <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>; Fabio
> Estevam <festevam@...il.com>; dl-linux-imx <linux-imx@....com>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Varun Sethi
> <V.Sethi@....com>; Gaurav Jain <gaurav.jain@....com>; Pankaj Gupta
> <pankaj.gupta@....com>; Sahil Malhotra <sahil.malhotra@....com>;
> Vabhav Sharma <vabhav.sharma@....com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@....com>; Rahul Kumar Yadav
> <rahulkumar.yadav@....com>; Nikhil Singla <nikhil.singla@....com>;
> linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
> polyval, xctr cipher test support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
> >     Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> >
> >     Issue:-
> >     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> >
> >     skcipher: failed to allocate transform for xctr(aes): -2
> >     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> >     alg: self-tests for sm3 using sm3 failed (rc=-2)
> >     tcrypt: failed to load transform for sm3: -2
> >     alg: hash: failed to allocate transform for polyval: -2
> >     alg: self-tests for polyval using polyval failed (rc=-2)
> >
> >     Resolution:-
> >     Enabling CONFIG_CRYPTO_SM3_GENERIC,
> CONFIG_CRYPTO_SM4_GENERIC,
> >     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
> support of
> >     sm3, sm4, aria, polyval & xctr.
> >
> >     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@....com>
> 
> The commit log and Signed-off-by lines shouldn't have leading
> spaces/indent. 
Checkpatch has not reported any such issues.
> 
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> > b/arch/arm/configs/imx_v6_v7_defconfig
> > index 0a90583f9f01..627f57da9d5b 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
> >  # CONFIG_SLUB_DEBUG is not set
> >  # CONFIG_SCHED_DEBUG is not set
> >  # CONFIG_FTRACE is not set
> > +CONFIG_CRYPTO_HCTR2=m
> > +CONFIG_CRYPTO_SM3_GENERIC=m
> > +CONFIG_CRYPTO_SM4_GENERIC=m
> > +CONFIG_CRYPTO_ARIA=m
> 
> Instead of adding lines at the end of file, please use help from 'make
> savedefconfig' to get them appear at the correct places.
Changes done in v2.
> 
> Shawn