linux-kernel - Re: iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in ipmmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c757d69-ec60-477c-a978-a94118a571a2@web.de>
Date: Mon, 5 Feb 2024 14:02:34 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
 kernel-janitors@...r.kernel.org, Jörg Rödel
 <joro@...tes.org>, Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in
 ipmmu_probe()

>>>> Thus reuse existing functionality instead of keeping duplicate source code.
>>>
>>> Much as I detest the get_and_ioremap_resource obfuscator, it's not even appropriate here since nothing else is using "res".
>>
>> I got the impression that this local variable is needed to perform
>> a desired function call.
>
> Yes, the call to devm_ioremap_resource(). Which you're proposing to remove...

I propose to replace a specific function call combination
by an other single call for a known wrapper function.
The mentioned variable is preserved for this purpose.

Regards,
Markus