linux-kernel - RE: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before destroying the changeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 13:10:33 +0000
From: "Sa, Nuno" <Nuno.Sa@...log.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki"
	<rafael@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Rob Herring
	<robh+dt@...nel.org>, Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus
	<heikki.krogerus@...ux.intel.com>,
        Sakari Ailus
	<sakari.ailus@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before
 destroying the changeset



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Monday, February 5, 2024 1:36 PM
> To: Sa, Nuno <Nuno.Sa@...log.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Rafael J. Wysocki
> <rafael@...nel.org>; Frank Rowand <frowand.list@...il.com>; Rob Herring
> <robh+dt@...nel.org>; Daniel Scally <djrscally@...il.com>; Heikki Krogerus
> <heikki.krogerus@...ux.intel.com>; Sakari Ailus <sakari.ailus@...ux.intelcom>;
> Len Brown <lenb@...nel.org>; linux-acpi@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before
> destroying the changeset
> 
> [External]
> 
> On Mon, Feb 05, 2024 at 01:09:33PM +0100, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <nuno.sa@...log.com>
> >
> > Device links will drop their supplier + consumer refcounts
> > asynchronously. That means that the refcount of the of_node attached to
> > these devices will also be dropped asynchronously and so we cannot
> > guarantee the DT overlay assumption that the of_node refcount must be 1 in
> > __of_changeset_entry_destroy().
> >
> > Given the above, call the new fwnode_links_flush_queue() helper to flush
> > the devlink workqueue so we can be sure that all links are dropped before
> > doing the proper checks.
> 
> Have you seen my comments against v1?

Hmm, not really. lei is not fetching any email (even this one - that's why I'm using my work email + awesome
email client to reply).
And looking directly in lore... I'm also not seeing any reply from you. Maybe there's an issue.

- Nuno Sá