linux-kernel - Re: [PATCH v3] keys: update key quotas in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il33f24c.fsf@suse.de>
Date: Mon, 05 Feb 2024 13:54:11 +0000
From: Luis Henriques <lhenriques@...e.de>
To: David Howells <dhowells@...hat.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>,  Eric Biggers
 <ebiggers@...nel.org>,  keyrings@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] keys: update key quotas in key_put()

David Howells <dhowells@...hat.com> writes:

> Luis Henriques <lhenriques@...e.de> wrote:
>
>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
>> been causing some issues in fscrypt testing, specifically in fstest
>> generic/581.  This commit fixes this test flakiness by dealing with the
>> quotas immediately, and leaving all the other clean-ups to the key garbage
>> collector.
>
> Okay, I'll accept this.
>

That's awesome, thanks a lot David.  And, as Eric requested, I'll send out
shortly a follow-up fscrypt-specific patch, which will make generic/581
fstest finally pass.

Cheers,
-- 
Luís


>> This is done by moving the updates to the qnkeys and qnbytes fields in
>> struct key_user from key_gc_unused_keys() into key_put().
>> Unfortunately, this also means that we need to switch to the
>> irq-version of the spinlock that protects these fields and use
>> spin_lock_{irqsave,irqrestore} in all the code that touches these
>> fields.
>
> ... Which shouldn't be that often.  It only happens when a key is created or
> finally let go of.
>
>> Signed-off-by: Luis Henriques <lhenriques@...e.de>
>
> Acked-by: David Howells <dhowells@...hat.com>
>
> Jarkko - could you pick this up?
>