linux-kernel - Re: [PATCH v2 06/23] gpio: add SRCU infrastructure to struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcDreg9pXqFX8zwa@smile.fi.intel.com>
Date: Mon, 5 Feb 2024 16:06:50 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Kent Gibson <warthog618@...il.com>, Alex Elder <elder@...aro.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	"Paul E . McKenney" <paulmck@...nel.org>,
	Wolfram Sang <wsa@...-dreams.de>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 06/23] gpio: add SRCU infrastructure to struct
 gpio_desc

On Mon, Feb 05, 2024 at 06:04:23AM -0800, Bartosz Golaszewski wrote:
> On Mon, 5 Feb 2024 14:57:45 +0100, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> said:
> > On Mon, Feb 05, 2024 at 02:54:08PM +0100, Bartosz Golaszewski wrote:
> >> On Mon, Feb 5, 2024 at 2:48 PM Andy Shevchenko
> >> <andriy.shevchenko@...ux.intel.com> wrote:
> >> > On Mon, Feb 05, 2024 at 10:34:01AM +0100, Bartosz Golaszewski wrote:

..

> >> > > +                     for (j = 0; j < i; j++)
> >> > > +                             cleanup_srcu_struct(&desc->srcu);
> >> >
> >> > What does this loop mean?
> >>
> >> I open-coded it because I want to store the value of i to go back and
> >> destroy the SRCU structs on failure.
> >
> > Where/how is j being used?
> >
> 
> In this bit:

I am sorry, but I don't see how...

>         for (i = 0; i < gc->ngpio; i++) {
>                 struct gpio_desc *desc = &gdev->descs[i];
> 
>                 ret = init_srcu_struct(&desc->srcu);
>                 if (ret) {
>                         for (j = 0; j < i; j++)
>                                 cleanup_srcu_struct(&desc->srcu);

So, you call the same several times, why?

>                         goto err_remove_of_chip;
>                 }

> >> > > +                     goto err_remove_of_chip;
> >> > > +             }

-- 
With Best Regards,
Andy Shevchenko