linux-kernel - Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240205155011.7f27bb07@xps-13>
Date: Mon, 5 Feb 2024 15:50:11 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Rob Herring <robh@...nel.org>
Cc: Zhenhua Huang <quic_zhenhuah@...cinc.com>,
 krzysztof.kozlowski+dt@...aro.org, quic_tingweiz@...cinc.com,
 richard@....at, vigneshr@...com, conor+dt@...nel.org,
 linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
 quic_bjorande@...cinc.com, devicetree@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from
 mtd.yaml

Hi,

robh@...nel.org wrote on Tue, 16 Jan 2024 11:10:05 -0600:

> On Wed, 10 Jan 2024 19:21:45 +0800, Zhenhua Huang wrote:
> > The mtd binding is always $ref'ed by other bindings, default selector
> > should be from other binding files which ref'ed it. Now, "$nodename" in
> > mtd.yaml turns into a "select" automatically such that a few binding check
> > issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> > rules in folder sram/*)
> > 
> > To avoid the automatically created "select" in mtd.yaml, adding:
> > 
> > select: false
> > 
> > Suggested-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> > Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> > Signed-off-by: Zhenhua Huang <quic_zhenhuah@...cinc.com>
> > ---
> > Hi Bjorn,
> > 
> > As the idea is from your comment, I added "Suggested-by" you.
> > Please tell me if that's not suitable. Thanks.
> > 
> >  Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >   
> 
> Acked-by: Rob Herring <robh@...nel.org>

Applied to mtd/next, thanks!

Miquèl