linux-kernel - Re: [PATCH 3/4] MIPS: PCI: Return PCIBIOS_* from tx4927_pci_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Feb 2024 15:52:55 +0100
From: Sergio Paracuellos <sergio.paracuellos@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, linux-mips@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] MIPS: PCI: Return PCIBIOS_* from tx4927_pci_config_read/write()

Hi,

On Mon, Feb 5, 2024 at 3:35 PM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:
>
> pci_ops .read/.write must return PCIBIOS_* codes but
> tx4927_pci_config_read/write() return -1 when mkaddr() cannot find
> devfn from the root bus. Return PCIBIOS_DEVICE_NOT_FOUND instead and
> pass that onward in the call chain instead of overwriting the return
> value.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  arch/mips/pci/ops-tx4927.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/arch/mips/pci/ops-tx4927.c b/arch/mips/pci/ops-tx4927.c
> index f7802f100401..4dd8b93985fb 100644
> --- a/arch/mips/pci/ops-tx4927.c
> +++ b/arch/mips/pci/ops-tx4927.c
> @@ -60,7 +60,7 @@ static int mkaddr(struct pci_bus *bus, unsigned int devfn, int where,
>  {
>         if (bus->parent == NULL &&
>             devfn >= PCI_DEVFN(TX4927_PCIC_MAX_DEVNU, 0))
> -               return -1;
> +               return PCIBIOS_DEVICE_NOT_FOUND;
>         __raw_writel(((bus->number & 0xff) << 0x10)
>                      | ((devfn & 0xff) << 0x08) | (where & 0xfc)
>                      | (bus->parent ? 1 : 0),

Should we also return PCIBIOS_SUCCESSFUL instead of 'return 0' in
'mkaddr' for coherency?

Other than that, changes look good to me.

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>

Thanks,
    Sergio Paracuellos

> @@ -140,10 +140,12 @@ static int tx4927_pci_config_read(struct pci_bus *bus, unsigned int devfn,
>                                   int where, int size, u32 *val)
>  {
>         struct tx4927_pcic_reg __iomem *pcicptr = pci_bus_to_pcicptr(bus);
> +       int ret;
>
> -       if (mkaddr(bus, devfn, where, pcicptr)) {
> +       ret = mkaddr(bus, devfn, where, pcicptr);
> +       if (ret != PCIBIOS_SUCCESSFUL) {
>                 *val = 0xffffffff;
> -               return -1;
> +               return ret;
>         }
>         switch (size) {
>         case 1:
> @@ -162,9 +164,11 @@ static int tx4927_pci_config_write(struct pci_bus *bus, unsigned int devfn,
>                                    int where, int size, u32 val)
>  {
>         struct tx4927_pcic_reg __iomem *pcicptr = pci_bus_to_pcicptr(bus);
> +       int ret;
>
> -       if (mkaddr(bus, devfn, where, pcicptr))
> -               return -1;
> +       ret = mkaddr(bus, devfn, where, pcicptr);
> +       if (ret != PCIBIOS_SUCCESSFUL)
> +               return ret;
>         switch (size) {
>         case 1:
>                 icd_writeb(val, where & 3, pcicptr);
> --
> 2.39.2
>
>