linux-kernel - Re: [PATCH v2 2/2] iio: adc: ti-ads1298: Add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcD/fnVVLdR2TFr1@finisterre.sirena.org.uk>
Date: Mon, 5 Feb 2024 15:32:14 +0000
From: Mark Brown <broonie@...nel.org>
To: Mike Looijmans <mike.looijmans@...ic.nl>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Liam Beguin <liambeguin@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Maksim Kiselev <bigunclemax@...il.com>,
	Marcus Folkesson <marcus.folkesson@...il.com>,
	Marius Cristea <marius.cristea@...rochip.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Okan Sahin <okan.sahin@...log.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads1298: Add driver

On Mon, Feb 05, 2024 at 04:25:19PM +0100, Mike Looijmans wrote:
> On 05-02-2024 14:55, Andy Shevchenko wrote:

> > > > +	.cache_type = REGCACHE_RBTREE,

> > Why not MAPPLE TREE?

> Reading the description this driver isn't a good candidate - the map isn't
> sparse and the hardware can do bulk read/write (though the driver doesn't
> use it).

If your driver is a good candidate for rbtree it's a good candidate for
maple tree.  There are very few specialist cases where there's an
advantage to sticking with rbtree.  The maple cache has no meaningful
overhead compared to rbtree for non-sparse regmaps and will generate
bulk writes just fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)