linux-kernel - Re: [linus:master] [remap_range] dfad37051a: stress-ng.file-ioctl.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxjFA=P8ZiPjaqP-4Ka35GdqEtKaTTG1XMnts6rOswchCA@mail.gmail.com>
Date: Tue, 6 Feb 2024 17:04:56 +0200
From: Amir Goldstein <amir73il@...il.com>
To: Oliver Sang <oliver.sang@...el.com>, Christian Brauner <brauner@...nel.org>
Cc: oe-lkp@...ts.linux.dev, lkp@...el.com, linux-kernel@...r.kernel.org, 
	Josef Bacik <josef@...icpanda.com>, Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>, 
	linux-fsdevel@...r.kernel.org, ying.huang@...el.com, feng.tang@...el.com, 
	fengwei.yin@...el.com
Subject: Re: [linus:master] [remap_range] dfad37051a: stress-ng.file-ioctl.ops_per_sec
 -11.2% regression

On Sun, Feb 4, 2024 at 8:33 AM Oliver Sang <oliver.sang@...el.com> wrote:
>
> hi, Amir,
>
> On Fri, Feb 02, 2024 at 11:13:56AM +0200, Amir Goldstein wrote:
> > On Wed, Jan 31, 2024 at 5:47 PM Amir Goldstein <amir73il@...il.com> wrote:
> > >
> > > On Wed, Jan 31, 2024 at 4:13 PM kenel test robot <oliver.sang@...el.com> wrote:
> > > >
> > > >
> > > >
> > > > Hello,
> > > >
> > > > kernel test robot noticed a -11.2% regression of stress-ng.file-ioctl.ops_per_sec on:
> > > >
> > > >
> > > > commit: dfad37051ade6ac0d404ef4913f3bd01954ee51c ("remap_range: move permission hooks out of do_clone_file_range()")
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > > >
> > >
> > > Can you please try this fix:
> > >
> > >  7d4213664bda remap_range: move sanity checks out of do_clone_file_range()
> > >
> > > from:
> > >
> > > https://github.com/amir73il/linux ovl-fixes
> > >
> >
> > Sorry, Oliver, this was a buggy commit.
> > I pushed this fixes version to ovl-fixes branch:
> >
> >  1c5e7db8e1b2 remap_range: merge do_clone_file_range() into
> > vfs_clone_file_range()
> >
> > Can you please test.
>
> the regression disappeared by above commit in our tests.
>
> I noticed this branch is based on v6.8-rc2, so I directly tested upon it and its
> parent (3f01e53bf6). I found 3f01e53bf6 has same data as dfad37051a we reported.
>
> and on 1c5e7db8e1b2, the performance back to the same level before dfad37051a.
>

Thanks for testing!

Christian, can you please amend the fix commit to
Reported-and-tested-by: kernel test robot <oliver.sang@...el.com>

Thanks,
Amir.