linux-kernel - [PATCH] fs/mnt_idmapping.c: Return -EINVAL when no map is written

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240206-mnt-idmap-inval-v1-1-68bfabb97533@me.com>
Date: Tue, 06 Feb 2024 15:17:52 +0000
From: Taylor Jackson via B4 Relay <devnull+taylor.a.jackson.me.com@...nel.org>
To: Alexander Viro <viro@...iv.linux.org.uk>, 
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
 Seth Forshee <sforshee@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Taylor Jackson <taylor.a.jackson@...com>
Subject: [PATCH] fs/mnt_idmapping.c: Return -EINVAL when no map is written

From: Taylor Jackson <taylor.a.jackson@...com>

This change will return an "invalid argument" error code when a map is
not provided when attempting to remap files using the id mapped mount
command, rather than returning nothing.

Signed-off-by: Taylor Jackson <taylor.a.jackson@...com>
---
 fs/mnt_idmapping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/mnt_idmapping.c b/fs/mnt_idmapping.c
index 64c5205e2b5e..3c60f1eaca61 100644
--- a/fs/mnt_idmapping.c
+++ b/fs/mnt_idmapping.c
@@ -214,7 +214,7 @@ static int copy_mnt_idmap(struct uid_gid_map *map_from,
 	 * anything at all.
 	 */
 	if (nr_extents == 0)
-		return 0;
+		return -EINVAL;
 
 	/*
 	 * Here we know that nr_extents is greater than zero which means

---
base-commit: 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
change-id: 20240206-mnt-idmap-inval-18d3a35f83fd

Best regards,
-- 
Taylor Jackson <taylor.a.jackson@...com>