linux-kernel - Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Feb 2024 17:53:51 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: frut3k7 <frut3k7@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
 Naresh Solanki <Naresh.Solanki@...ements.com>,
 Patrick Rudolph <patrick.rudolph@...ements.com>,
 Peter Yin <peteryin.openbmc@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Michal Simek <michal.simek@....com>, Lakshmi Yadlapati
 <lakshmiy@...ibm.com>, Lukas Wunner <lukas@...ner.de>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Fabio Estevam <festevam@...x.de>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

On 06/02/2024 17:34, frut3k7 wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>>>> index 79dcd92c4a43..50efbdf2a735 100644
>>>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>>>> @@ -309,6 +309,8 @@ properties:
>>>>>            - plx,pex8648
>>>>>              # Pulsedlight LIDAR range-finding sensor
>>>>>            - pulsedlight,lidar-lite-v2
>>>>> +            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
>>>>> +          - qca,spidev
>>>>
>>>> There is no such hardware as spidev and you even mentioned it is called
>>>> QCA4024, not spidev. Please don't use that name but a real name.
>>>>
>>> The compatibility will be changed to "qca4024" and a new patch version
>>> will be prepared.
>>
>> That would be ok except:
>>
>>>
>>>> Also, I have doubts that Bluetooth is a trivial device. Such devices
>>>> need supplies, have reset/powerdown GPIOs.
>>
>> this is not resolved. Bluetooth chips are not trivial devices. This one
>> particular exposes several interfaces to the host, needs a clock and
>> power supply.
>>
> Device is used over QUP4 SPI controller inside of IPQ8074:
> https://lore.kernel.org/all/20231123121324.1046164-1-robimarko@gmail.com/
> I'm not sure if these pin settings should be upstreamed as they are
> specific to this platform:
> https://github.com/openwrt/openwrt/pull/14051/files#diff-ed3fbf0226fbdc76c9c160f2f2b9e988120df472480b9861abe7a46796558115R81-R111

Why do you think qca4024 is specific to this platform? Judging by
Qualcomm website: it is not.

Best regards,
Krzysztof