[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0b758df7-8583-48d1-b289-a297890344f4@ti.com>
Date: Tue, 6 Feb 2024 11:48:05 -0600
From: Andrew Davis <afd@...com>
To: Markus Schneider-Pargmann <msp@...libre.com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
Rob
Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Santosh Shilimkar
<ssantosh@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] arm64: dts: ti: k3-am62-wakeup: Add chip efuse nodes
On 2/6/24 8:37 AM, Markus Schneider-Pargmann wrote:
> Add efuse nodes describing chip variant and speed grade.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 36 +++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> index fef76f52a52e..14419df43624 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> @@ -14,10 +14,44 @@ wkup_conf: syscon@...00000 {
> #size-cells = <1>;
> ranges = <0x0 0x00 0x43000000 0x20000>;
>
> + wkup_efuse: efuse@0 {
> + compatible = "socionext,uniphier-efuse";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x0 0x200>;
> +
> + nvmem-layout {
> + compatible = "fixed-layout";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + chip_manufacturer: jtagidmfg@14 {
> + reg = <0x14 0x2>;
> + bits = <1 11>;
> + };
> +
> + chip_partno: jtagidpartno@15 {
> + reg = <0x15 0x3>;
> + bits = <4 16>;
> + };
> +
> + chip_variant: jtagidvariant@17 {
> + reg = <0x17 0x1>;
> + bits = <4 4>;
> + };
> +
> + chip_speed: jtaguseridspeed@18 {
> + reg = <0x18 0x4>;
> + bits = <6 5>;
> + };
> + };
> + };
> +
> chipid: chipid@14 {
If you remove the reg property you will want to drop the @14
also or you will get a DT check warning. That needs fixed
in the binding example too (and the binding nodename pattern).
Andrew
> bootph-all;
> compatible = "ti,am654-chipid";
> - reg = <0x14 0x4>;
> + nvmem-cells = <&chip_variant>, <&chip_partno>, <&chip_manufacturer>;
> + nvmem-cell-names = "chipvariant", "chippartno", "chipmanufacturer";
> };
> };
>
Powered by blists - more mailing lists