linux-kernel - RE: [KTAP V2 PATCH v2] ktap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 6 Feb 2024 18:15:02 +0000
From: "Bird, Tim" <Tim.Bird@...y.com>
To: Rae Moar <rmoar@...gle.com>, Kees Cook <kees@...nel.org>
CC: "frowand.list@...il.com" <frowand.list@...il.com>,
        "davidgow@...gle.com"
	<davidgow@...gle.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "brendanhiggins@...gle.com"
	<brendanhiggins@...gle.com>,
        "dlatypov@...gle.com" <dlatypov@...gle.com>,
        "tytso@...gle.com" <tytso@...gle.com>,
        "gustavo.padovan@...labora.com"
	<gustavo.padovan@...labora.com>,
        "ricardo.canuelo@...labora.com"
	<ricardo.canuelo@...labora.com>,
        "guillaume.tucker@...labora.com"
	<guillaume.tucker@...labora.com>,
        "corbet@....net" <corbet@....net>,
        "kernelci@...ts.linux.dev" <kernelci@...ts.linux.dev>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "kunit-dev@...glegroups.com" <kunit-dev@...glegroups.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [KTAP V2 PATCH v2] ktap_v2: add test metadata

> -----Original Message-----
> From: Rae Moar <rmoar@...gle.com>
> On Sun, Feb 4, 2024 at 8:03 AM Kees Cook <kees@...nel.org> wrote:
> >
> > On January 26, 2024 11:14:26 PM GMT+01:00, Rae Moar <rmoar@...gle.com> wrote:
> > > KTAP version 2
> > > # ktap_test: main
> > > # ktap_arch: uml
> > > 1..1
> > >     KTAP version 2
> > >     # ktap_test: suite_1
> > >     # ktap_subsystem: example
> > >     # ktap_test_file: lib/test.c
> >
> > I think it's a mistake to mix "diagnostics" lines with semantic lines. Since the diagnostic prefix is [# ] (hash space) how about make the test
> metadata lines be [#:] (hash colon). For example:
> >
> >
> >      1..2
> >      ok 1 test_1
> >      #:ktap_test: test_2
> >      #:ktap_speed: very_slow
> >      #:custom_is_flaky: true
> >      # format-free stuff goes here
> >      ok 2 test_2
> > ...
> 
> Hello!
> 
> I really like this idea. The reason I chose the diagnostic line format
> was to make it easier for existing parsers to parse the KTAP Metadata
> lines. However, if it won't be too much of an issue for current
> parsers, I think this idea would be better. So I am happy to change
> this in the next version if there are no complaints.

I like this suggestion as well.  So this response is the opposite of a complaint.
 -- Tim