linux-kernel - Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a21789-9253-4185-98ed-e335d0167df4@alliedtelesis.co.nz>
Date: Tue, 6 Feb 2024 21:41:10 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "robh+dt@...nel.org"
	<robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "jdelvare@...e.com" <jdelvare@...e.com>,
	"linux@...ck-us.net" <linux@...ck-us.net>, "antoniu.miclaus@...log.com"
	<antoniu.miclaus@...log.com>, "noname.nuno@...il.com"
	<noname.nuno@...il.com>, "linux-rtc@...r.kernel.org"
	<linux-rtc@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
	Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
Subject: Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs


On 7/02/24 10:12, Alexandre Belloni wrote:
> On 06/02/2024 20:19:20+0000, Chris Packham wrote:
>> That is an incredibly good point. The max31335 binding covers one specific chip. This binding covers more and with that there are a few more properties that the max31335 on it's own doesn't have (e.g. the clock consumer, the ability to have different i2c addresses). Binding wise I could probably roll all of the max31335 into this max313xx binding.
>>
>> Driver wise things are a bit trickier. I've only got access to one of
>> the variants so I am hoping to leverage the work Ibrahim had already
>> done. I could attempt to incorporate max31335 support into the
>> max313xx driver but I wouldn't really be able to test it properly and
>> there is a reasonably high chance of regressing something.
> But I won't take a separate driver. Everything would be better if Analog
> was sharing the datasheets...

The datasheets are pretty accessible so I'd give Analog a pass on that 
(they're certainly better than some vendors). I'll include some links on 
the next update.

I'll attempt to roll the max31335 into the max313xx driver.