linux-kernel - Re: [PATCH 17/17] vfio/pci: Remove duplicate interrupt management flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541fcb26-8f37-491f-bec2-49efb0693c2a@intel.com>
Date: Tue, 6 Feb 2024 13:46:46 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: Alex Williamson <alex.williamson@...hat.com>
CC: <jgg@...dia.com>, <yishaih@...dia.com>,
	<shameerali.kolothum.thodi@...wei.com>, <kevin.tian@...el.com>,
	<kvm@...r.kernel.org>, <dave.jiang@...el.com>, <ashok.raj@...el.com>,
	<linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>
Subject: Re: [PATCH 17/17] vfio/pci: Remove duplicate interrupt management
 flow

Hi Alex,

On 2/5/2024 2:35 PM, Alex Williamson wrote:
> On Thu,  1 Feb 2024 20:57:11 -0800
> Reinette Chatre <reinette.chatre@...el.com> wrote:

..

>> @@ -799,11 +765,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev,
>>  		if (!ctx || !ctx->trigger)
>>  			continue;
>>  		if (flags & VFIO_IRQ_SET_DATA_NONE) {
>> -			eventfd_signal(ctx->trigger);
>> +			intr_ops[index].send_eventfd(vdev, ctx);
>>  		} else if (flags & VFIO_IRQ_SET_DATA_BOOL) {
>>  			uint8_t *bools = data;
> 
> Nit, an opportunity to add the missing new line between variable
> declaration and code here.  Thanks,

Will do. Thank you.

Reinette